Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update worldedit-neoforge.mixins.json to use java 21 #2683

Closed

Conversation

Thunderrock424242
Copy link

since we are in minecraft 1.21 we should be using java 21 to use mixins

since we are in minecraft 1.21 we should be using java 21 to use mixins
@Thunderrock424242 Thunderrock424242 requested a review from a team as a code owner December 25, 2024 19:09
@me4502
Copy link
Member

me4502 commented Jan 2, 2025

Is this correct? when MC started requiring Java 21, the general consensus was that it had to remain set to JAVA_17 due to some issues that i don't entirely recall. have these issues been resolved now? if so, this probably also would need to change in the Fabric distribution of WorldEdit too?

@wizjany
Copy link
Collaborator

wizjany commented Jan 5, 2025

The docs indicate

compatibilityLevel should always be set to the highest level required by your mixins.

So as long as there's no breaking ("non-upgrade-able") changes between 17 and 21 (there aren't, obviously, since our mixins run fine on 21), this shouldn't actually matter. It doesn't really have anything to do with MC version outside of the fact that Mojang is now bumping Java version more liberally as opposed to the past where we were stuck on Java8 forever.
If we wanted to pedantically have the mixin level to match the MC version/target build version/whatever, I'd rather do it via gradle resource replacement and have it apply equally across the project. At the very least, there's no reason to update the NF one here without the Fabric one even without automation.

@wizjany wizjany closed this Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants