[Performance] Read Bazel profile as a stream #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of reading the Bazel profile all at once, use a stream to reduce memory consumption. Benchmark with a Bazel profile of unzipped size 357MB Using YourKit as a profiler and checking the shallow size at the end of the `BazelProfile` constructor: Before: 3.6 GB After: 349 MB Contributes to #163 Signed-off-by: Sara Adams <[email protected]>
ulfjack
reviewed
Dec 21, 2023
| throw new IllegalArgumentException("Could not parse Bazel profile.", e); | ||
| } | ||
| return new BazelProfile(bazelProfile); | ||
| return new BazelProfile(new JsonReader(new InputStreamReader(inputStream))); |
There was a problem hiding this comment.
When constructing an InputStreamReader, you should always pass in a Charset, such as StandardCharsets.UTF_8.
ulfjack
reviewed
Dec 21, 2023
| TraceEventFormatConstants.SECTION_OTHER_DATA, | ||
| TraceEventFormatConstants.SECTION_TRACE_EVENTS)); | ||
| } | ||
| private BazelProfile(JsonReader profileReader) { |
There was a problem hiding this comment.
Stylistically, it is not recommended to do significant work in a constructor. It would be better to refactor this code and do the parsing in a static method or a builder class, and then construct the object with just the required fields. While at it, it may also make sense to use immutable maps for the fields.
ulfjack
approved these changes
Dec 21, 2023
Signed-off-by: Sara Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of reading the Bazel profile all at once, use a stream to reduce memory consumption.
Benchmark with a Bazel profile of unzipped size 357MB
Using YourKit as a profiler and checking the shallow size at the end of the
BazelProfileconstructor:Before: 3.6 GB
After: 349 MB
Contributes to #163