-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Instances in Custom Directories #443
base: settings-tab
Are you sure you want to change the base?
Install Instances in Custom Directories #443
Conversation
I'd much prefer if instead of doing it during the install, the option to change install dir is located in the settings. That's not in master yet, but there's a |
# Conflicts: # Cargo.lock # src/main.rs # src/settings.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not sure which option is best here:
- Give the user the option to select a custom directory, and fall back to appdata if it's not used
- have one setting for "install dir" which is set to the appdata directory by default
I was personally leaning towards the latter, but also requires us to move the install dir whenever the value is changed, which is a bit more effort in terms of UI.
Cargo.toml
Outdated
"advanced", | ||
"image", | ||
"tokio", | ||
"wgpu", # tiny-skia backend panics with small text boxes, fixed in latest master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a link to the issue, and do you know if the fix has already been released? I'd like to avoid bouncing around between tiny-skia and wgpu with every release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a link to the issue, and do you know if the fix has already been released? I'd like to avoid bouncing around between tiny-skia and wgpu with every release.
Looks like I was wrong, the issue hasn't been fixed yet. I'll change the comment.
It's easier to do the former (that's why I went that way in the first place), but if we really need the latter I'm willing to do it. |
Fixes #373