Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Instances in Custom Directories #443

Open
wants to merge 6 commits into
base: settings-tab
Choose a base branch
from

Conversation

Koranir
Copy link
Contributor

@Koranir Koranir commented Jul 6, 2024

Fixes #373

image

image

@MCOfficer
Copy link
Member

I'd much prefer if instead of doing it during the install, the option to change install dir is located in the settings. That's not in master yet, but there's a settings-tab branch you can work with.

@MCOfficer MCOfficer changed the base branch from master to settings-tab July 7, 2024 08:28
Copy link
Member

@MCOfficer MCOfficer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure which option is best here:

  • Give the user the option to select a custom directory, and fall back to appdata if it's not used
  • have one setting for "install dir" which is set to the appdata directory by default

I was personally leaning towards the latter, but also requires us to move the install dir whenever the value is changed, which is a bit more effort in terms of UI.

Cargo.toml Outdated
"advanced",
"image",
"tokio",
"wgpu", # tiny-skia backend panics with small text boxes, fixed in latest master.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link to the issue, and do you know if the fix has already been released? I'd like to avoid bouncing around between tiny-skia and wgpu with every release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a link to the issue, and do you know if the fix has already been released? I'd like to avoid bouncing around between tiny-skia and wgpu with every release.

Looks like I was wrong, the issue hasn't been fixed yet. I'll change the comment.

iced-rs/iced#2332

@Koranir
Copy link
Contributor Author

Koranir commented Jul 11, 2024

I was personally leaning towards the latter, but also requires us to move the install dir whenever the value is changed, which is a bit more effort in terms of UI.

It's easier to do the former (that's why I went that way in the first place), but if we really need the latter I'm willing to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portable mode
2 participants