Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FYP patch #10

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

FYP patch #10

wants to merge 6 commits into from

Conversation

stevefan1999
Copy link
Contributor

Summary:

  1. Use Gradle instead of Maven
  2. Changed all getEnvironment calls to properties
  3. Added evaluator
  4. Added secure runtime
  5. Rewritten some code to use Lombok
  6. Added Lab metadata support
  7. No longer using detached threads to run timer tasks

@stevefan1999 stevefan1999 changed the base branch from master to dev April 26, 2022 12:54
@EndangeredF1sh EndangeredF1sh added the enhancement New feature or request label Apr 27, 2022
EndangeredF1sh
EndangeredF1sh reviewed Apr 28, 2022
View reviewed changes
src/main/java/hk/edu/polyu/comp/vlabcontroller/api/ProxyRouteController.java
this.mappingManager = mappingManager;
this.environment = environment;
}
private final ServerProperties serverProperties;

@RequestMapping(value = "/api/route/**")
Copy link
Owner

@EndangeredF1sh EndangeredF1sh Apr 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can rewrite with @PathVariable here

@EndangeredF1sh EndangeredF1sh self-assigned this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndangeredF1sh EndangeredF1sh EndangeredF1sh left review comments

Assignees

@EndangeredF1sh EndangeredF1sh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevefan1999 @EndangeredF1sh