Hotfix/mongo auth

manifests/profile/mongodb.pp

@@ -39,6 +39,9 @@
   $manage_repo = $st2::mongodb_manage_repo,
   $auth        = $st2::mongodb_auth,
 ) inherits st2 {
+  # Define the marker file path
+  $marker_file = '/etc/.mongodb_auth_init'
+
   # if Ubuntu is 20.04 then MongoDB 4.4
   # if the StackStorm version is > 3.3.0 then MongoDB 4.0
   # if the StackStorm version is > 2.4.0 then MongoDB 3.4
@@ -92,12 +95,17 @@
       # on the admin database.
       #
       # The code below fixes this by first disabling auth, then creates the
-      # database, the re-enables auth.
+      # database, then re-enables auth.
       #
-      # To prevent this from running every time we've create a puppet fact
-      # called $mongodb_auth_init that is set when
-      if !$facts['mongodb_auth_init'] {
-        # unfortinately there is no way to synchronously force a service restart
+      # To prevent this from running every time, we use a marker file
+      # located at /etc/.mongodb_auth_init to indicate that
+      # the initialization is complete.
+      file { $marker_file:
+        ensure => absent,
+      }
+
+      if !defined(File[$marker_file]) {
+        # unfortunately there is no way to synchronously force a service restart
         # in Puppet, so we have to revert to exec... sorry
         include mongodb::params
         $_mongodb_stop_cmd = "systemctl stop ${mongodb::params::service_name}"
@@ -116,9 +124,6 @@
           refreshonly => true,
           path        => $_mongodb_exec_path,
         }
-        facter::fact { 'mongodb_auth_init':
-          value => bool2str(true),
-        }
 
         # start mongodb with auth disabled
         exec { 'mongodb - start service':
@@ -153,14 +158,18 @@
           timeout => '240',
         }
 
+        # Create the marker file to indicate initialization is complete
+        file { $marker_file:
+          ensure  => file,
+          content => 'Initialization complete',
+        }
 
         # ensure MongoDB config is present and service is running
         Class['mongodb::server::config']
         -> Class['mongodb::server::service']
         # stop mongodb; disable auth
         -> Exec['mongodb - stop service']
         ~> Exec['mongodb - disable auth']
-        ~> Facter::Fact['mongodb_auth_init']
         # start mongodb with auth disabled
         ~> Exec['mongodb - start service']
         # create mongodb admin database with auth disabled
@@ -231,5 +240,4 @@
       require  => Class['mongodb::server'],
     }
   }
-
 }

manifests/profile/web.pp

@@ -126,6 +126,7 @@
     ssl_redirect => true,
     add_header   => $add_header,
     tag          => ['st2', 'st2::frontend', 'st2::frontend::http'],
+    notify       => Service['nginx'],
   }
 
   # convert arrays into strings if necessary
@@ -164,6 +165,7 @@
       ],
     },
     tag                  => ['st2', 'st2::frontend', 'st2::frontend::https'],
+    notify               => Service['nginx'],
   }
 
   # default settings for all locations