Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Manage IPA groups and IPA group memberships #11

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

nmaludy
Copy link
Member

@nmaludy nmaludy commented Jan 26, 2021

No description provided.

@nmaludy nmaludy requested review from bishopbm1 and paxri01 January 26, 2021 16:29
@nmaludy
Copy link
Member Author

nmaludy commented Jan 26, 2021

@bishopbm1 wait for this until the tests are passing

@bishopbm1
Copy link
Contributor

yea i saw thats why i didn't merge yet. Changes looked good though!

@nmaludy
Copy link
Member Author

nmaludy commented Jan 27, 2021

@bishopbm1 i got tests to pass, keep holding on this, i want to add new unit tests please

@nmaludy nmaludy changed the title Manage IPA groups and IPA group memberships [WIP] Manage IPA groups and IPA group memberships Jan 27, 2021
@nmaludy nmaludy force-pushed the feature/ipa-groups branch from 4a24c55 to 620109e Compare January 27, 2021 02:32
Copy link

@paxri01 paxri01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, can't comment much on ruby scripts.

@paxri01
Copy link

paxri01 commented Feb 26, 2021

Also note, will need to update README.txt with user/group changes.

@nmaludy nmaludy force-pushed the feature/ipa-groups branch from 25f1ade to 0eee490 Compare February 2, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants