Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Commit

Permalink
keydb: 0.8.0
Browse files Browse the repository at this point in the history
* Remove `replicaServeStaleData` as rarely used and incompatibe with master - master mode when set to "no"
* Add `configExtraArgs` hashmap of additional paramters. Will be added to run script in form `--<key> <value>` or just `--<key>` if there is no vaule needed
  • Loading branch information
Antiarchitect committed Apr 16, 2020
1 parent 0bd329e commit 57c7599
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 4 deletions.
2 changes: 1 addition & 1 deletion keydb/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: keydb
description: A Helm chart for KeyDB multimaster setup
type: application
version: 0.7.1
version: 0.8.0
keywords:
- keydb
- redis
Expand Down
2 changes: 1 addition & 1 deletion keydb/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@ The following table lists the configurable parameters of the KeyDB chart and the
| `persistentVolume.accessModes` | Volume access modes | `[ReadWriteOnce]` |
| `persistentVolume.size` | Size of the volume | `1Gi` |
| `persistentVolume.storageClass` | StorageClassName for volume | `"-"` |
| `replicaServeStaleData` | KeyDB replica-serve-stale-data setting | `"yes"` |
| `configExtraArgs` | Additional configuration arguments for KeyDB | `{}` |
| `resources` | K8s Resources for KeyDB containers | `{}` |
| `securityContext` | K8s SecurityContext for KeyDB pods | `{}` |
8 changes: 7 additions & 1 deletion keydb/templates/cm-utils.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,16 @@ data:
--bind 0.0.0.0 \
--port "$port" \
--protected-mode no \
--replica-serve-stale-data {{ .Values.replicaServeStaleData }} \
--server-threads {{ .Values.threads | int }} \
{{- if .Values.password }}
--masterauth {{ .Values.password }} \
--requirepass {{ .Values.password }} \
{{- end }}
{{- range $key, $value := .Values.configExtraArgs }}
{{- if $value }}
--{{ $key }} {{ $value }} \
{{- else }}
--{{ $key }} \
{{- end }}
{{- end }}
"${replicas[@]}"
3 changes: 2 additions & 1 deletion keydb/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ port: 6379

threads: 2

configExtraArgs: {}

appendonly: "no"
replicaServeStaleData: "yes"

persistentVolume:
enabled: true
Expand Down

0 comments on commit 57c7599

Please sign in to comment.