Hot fix: Update SB3 to use new visualizer code #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daphne-cornelisse
requested review from
eugenevinitsky,
aaravpandya and
nadarenator
aaravpandya
reviewed
Dec 19, 2024
Comment on lines
-250
to
-277
| def render(self, world_render_idx=0, color_objects_by_actor=None): | ||
| """Renders the environment. | ||
|
|
||
| Args: | ||
| world_render_idx (int): Index of the world to render. | ||
|
|
||
| Returns: | ||
| Any: Rendered view of the world, or None if an invalid index is specified. | ||
| """ | ||
| if world_render_idx >= self.num_worlds: | ||
| print(f"Invalid world_render_idx: {world_render_idx}") | ||
| return None | ||
| if self.render_config.render_mode in { | ||
| RenderMode.PYGAME_ABSOLUTE, | ||
| RenderMode.PYGAME_EGOCENTRIC, | ||
| RenderMode.PYGAME_LIDAR, | ||
| }: | ||
| return self.visualizer.getRender( | ||
| world_render_idx=world_render_idx, | ||
| cont_agent_mask=self.cont_agent_mask, | ||
| color_objects_by_actor=color_objects_by_actor, | ||
| ) | ||
| elif self.render_config.render_mode in { | ||
| RenderMode.MADRONA_RGB, | ||
| RenderMode.MADRONA_DEPTH, | ||
| }: | ||
| return self.visualizer.getRender() | ||
|
|
There was a problem hiding this comment.
This is removing the render method? I am not sure I follow whats happening.
There was a problem hiding this comment.
Yes I replaced the renderer with a simpler matplotlib version
aaravpandya
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #313
A PR adding docs for the new viz with all features is on its way and should be ready by the end of the week.