Teleport on agent done #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaravpandya
requested review from
eugenevinitsky,
SamanKazemkhani and
daphne-cornelisse
|
Do these pass the pytests? If so, and this is reviewed, I'd like to merge this sometime today for training agents |
SamanKazemkhani
approved these changes
May 23, 2024
Comment on lines
+292
to
+296
| position = consts::kPaddingPosition; | ||
| velocity.linear.x = 0; | ||
| velocity.linear.y = 0; | ||
| velocity.linear.z = 0; | ||
| velocity.angular = Vector3::zero(); |
There was a problem hiding this comment.
I don't understand why you zero-out velocities here.
There was a problem hiding this comment.
Doesn't seem to be necessary but also doesn't hurt?
There was a problem hiding this comment.
Yes. It's just to be explicit. In the future, when we remove the agentZeroVelSystem, it would be useful to make sure velocities are zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Title.
rebased on #126 to fix the position where they get teleported to.