SS improvement with ACL groups #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is red. |
| @@ -127,6 +127,9 @@ | |||
| <xpath expr="//tree" position="inside"> | |||
| <field name="sale_shipment_id" readonly='1'/> | |||
| </xpath> | |||
| <xpath expr="//tree/field[@name='state']" position="before"> | |||
| <field name="is_preparation" /> | |||
There was a problem hiding this comment.
this field needs to be added at SOL level no?
|
I am not sure you will get travis green for Minimax before some time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is responsible for some placle:
View improvement
No need in form view. Add it in tree view (the one from the menu Sale Order Lines), before status
Add 3 ACL groups
sales shipment - manager
=> can manage all sales shipments (all buttons etc.)
sales shipment - user
=> can assign SOL, assign final quantity, remove SOL in draft. Cannot modify/delete Max Quantities, cannot confirm all SOL or cannot close shipment.
warehouse - sale shipment with following:Add menu Sale shipment in warehouse/Receive/Deliver Products (before last)
=> can see sale shipment but cannot modify anything
Add menu Sale order lines in warehouse/Receive/Deliver Products (last)
=> can see sales order lines but can only modify the checkbox in SOL ("Preparation")
Some modification may not be finished, I'm working on them asap.