Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Avoid versioning problems by using peer dependencies #322

Closed

Conversation

thewilkybarkid
Copy link

Dependabot opened a PR (PREreview/coar-notify#3) which sees multiple versions of @effect/platform and @effect/schema, leading to a broken build as they depend on different versions of effect.

While Dependabot shouldn't be getting as far as opening a PR that can't be installed, I'm guessing that using peer dependencies instead would get around this.

Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 0026467

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@effect/platform-browser Patch
@effect/platform-node Patch
@effect/platform-bun Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thewilkybarkid
Copy link
Author

Same problem when it tries to update @effect/schema: PREreview/coar-notify#4

@tim-smart
Copy link
Member

This has been addressed :)

@tim-smart tim-smart closed this Dec 14, 2023
@thewilkybarkid thewilkybarkid deleted the peer-dependencis branch December 14, 2023 21:49
@thewilkybarkid
Copy link
Author

Turns out this doesn't entirely fix Dependabot (PREreview/coar-notify#18). I'm guessing it doesn't update prerelease versions. (As they all pin a version of effect I'd hoped it would do a batch update of all the Effect packages.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants