Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change uniqueId #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cedryck1
Copy link

@cedryck1 cedryck1 commented Dec 18, 2022

To fix the problem of notes from pdf not being created.

Example in pdf.lua file from Koreader :

["bookmarks"] = {
[1] = {
["page"] = 286,
["chapter"] = "12. Routines: Workout Programs",
["datetime"] = "2022-12-07 22:17:38",
["notes"] = "True brawn and power are developed by hard training sessions, not by long training sessions. Quality over quantity is an excellent motto for strength.",
["pos0"] = {
["page"] = 286,
["x"] = 113.53055169962,
["rotation"] = 0,
["y"] = 94.348024444745,
["zoom"] = 2.4036458333333,
},
["pos1"] = {
["page"] = 286,
["x"] = 355.4808284805,
["rotation"] = 0,
["y"] = 104.26570541035,
["zoom"] = 2.4036458333333,
},

pos0 and pos1 not always a string, using datetime instead for uniqueId.

pos0 and pos1 not always a string, using datetime instead for uniqueId
@Edo78
Copy link
Owner

Edo78 commented Jan 6, 2025

I'm back in business!

First of all, thank you so much for this PR, and my sincerest apologies for the very late reply.

What kept me from merging it sooner is the concern that it might break compatibility with previous versions of the plugin or affect existing notes. I really appreciate your approach, and I see a lot of value in the direction you've taken.

Before integrating it, I want to make sure that older notes remain intact and that users upgrading to the new version won't face unexpected issues.

Thank you again for your contribution—it’s incredibly motivating to see this level of engagement. I’ll keep everyone posted on my progress, and I recommend subscribing to notifications to stay updated on future releases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants