Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automatic install of phpcpd #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Florian-B
Copy link

Remove phpcpd from composer requirements.
The sebastian/phpcpd package is abandoned => https://github.com/sebastianbergmann/phpcpd

see: #259

@juanjol
Copy link

juanjol commented Feb 22, 2024

Hi @Florian-B I'm sorry, I created another PR deleting phpcpd #264. I had not seen this one you had created. Anyway, the one I created I think it removes all reference to phpcpd both code and documentation, so I would say it is more complete. Do you think it would be better to work on this one I created?

@Florian-B
Copy link
Author

Hello @juanjol !

I don't have a preference, my PR has just removed the automatic installation of phpcpd which therefore allows phpcpd to be used with PHPqa.

Your PR removes all references to phpcpd, so it is a BC break in use since phpcpd can no longer be used with PHPqa.

I no longer use phpcpd on my projects so both solution are OK for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants