added prettier,husky and lint-staged. #71
Conversation
rahulkhattri0
commented
Nov 18, 2021
•
rahulkhattri0
commented
package.json
Outdated
| @@ -28,7 +28,8 @@ | |||
| "build": "npm run generate && react-scripts build", | |||
| "start:prod": "serve -s build", | |||
| "test": "react-scripts test", | |||
| "eject": "react-scripts eject" | |||
| "eject": "react-scripts eject", | |||
| "prepare": "husky install" | |||
| }, | |||
| "eslintConfig": { | |||
| "extends": [ | |||
There was a problem hiding this comment.
why is there this config in eslintConfig?
There was a problem hiding this comment.
I was using eslint before but because of some bug I had to remove that dependency. I'll remove eslintconfig from package.json.
There was a problem hiding this comment.
I removed node modules and package-lock.json from my project directory. Then, I removed eslint from devDependencies and then ran npm install. I forgot to remove eslintconfig from package.json.
|
removed eslint config from package.json |
|
ok ill remove lint staged |
|
please tell me how to install "lint" package locally |
it is a npm-script in package.json which basically runs eslint |
|
should i just setup husky? |
|
and you can run eslint using lint staged too |
Yeah that would work too... |
|
ok so ill just setup husky with a pre commit hook and the person who has been assigned to setup eslint can add lint. |
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| npx lint-staged |
There was a problem hiding this comment.
I think lint-staged is too late, we use the standard lint, please update.
Here is an example https://github.com/EddieHubCommunity/LinkFree/blob/main/.husky/pre-commit
