Add ConditionInfo object and example TextMergeConditionInfo for segment conditions #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any movement on this? I would like to use maleorang in my project but not having full support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
conditionsfield inSegmentOptsInfofromArray<String>?toArray<ConditionInfo>so more complex segments can be configured when creating campaigns.I included the
TextMergeConditionInfoclass because that is the condition that I needed in my project but the baseConditionInfoclass is open so other sub classes can be easily added.This change is kind of not backwards compatible because it changes the type of the
conditionsfield so existing code that uses that field as an array of strings will not work anymore. Although I don't know why anyone would use the field like that so I don't think it's an issue.