ECWID-126274 OE2: The discount Based on Customer Groups is deducted f… #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom the gift card: added isGiftCard into order and cart
…rom the gift card: changed var to val, fixed test
…rom the gift card: changed ignoreNullable to AllowNullable
…rom the gift card: added AllowNullable in rules
…rom the gift card: changed another one ignoreNullable to allowNullable
…rom the gift card: changed name isGiftCard to giftCard to correct rest4j mapping
…rom the gift card: changed generated value for giftCard in tests from randomBoolean to false - for true need new test
kitty-ecwid
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECWID-126274 OE2: The discount Based on Customer Groups is deducted from the gift card: added isGiftCard into order and cart