Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ObservationPoints script #200

Merged
merged 5 commits into from
Oct 17, 2023
Merged

remove ObservationPoints script #200

merged 5 commits into from
Oct 17, 2023

Conversation

SarahAlidoost
Copy link
Member

@SarahAlidoost SarahAlidoost commented Oct 10, 2023 •
edited
Loading

Description

closes #101 . I tested this branch with three site data. The results are the same as those generated by the main branch.

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Add changes to the changelog file under section Unreleased.
  • Model runs successfully.
  • Ask a meinatainer to re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

@SarahAlidoost SarahAlidoost marked this pull request as ready for review October 10, 2023 15:46
@SarahAlidoost SarahAlidoost mentioned this pull request Oct 12, 2023
Merged
9 tasks
BSchilperoort
BSchilperoort approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be nice to still try to improve the names of variables.

Otherwise it looks good 👍

src/STEMMUS_SCOPE.m Outdated Show resolved Hide resolved
src/STEMMUS_SCOPE.m Outdated Show resolved Hide resolved
SarahAlidoost and others added 2 commits October 17, 2023 16:09
@SarahAlidoost @BSchilperoort
Update src/STEMMUS_SCOPE.m
00eb564 
Co-authored-by: Bart Schilperoort <[email protected]>
@SarahAlidoost @BSchilperoort
Update src/STEMMUS_SCOPE.m
02556cf 
Co-authored-by: Bart Schilperoort <[email protected]>
@SarahAlidoost SarahAlidoost merged commit 8e2642f into main Oct 17, 2023
1 check passed
@SarahAlidoost SarahAlidoost deleted the fix_issue_101 branch October 17, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSchilperoort BSchilperoort BSchilperoort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor ObservationPoints
2 participants
@SarahAlidoost @BSchilperoort