Add missing API key retrieval examples #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Justintime50
requested changes
Sep 29, 2023
There was a problem hiding this comment.
There are two inconsistencies I'd like fixed here please:
- In some examples we retrieve the user then pass in the ID. Let's either forgo that on all examples and just pass in a fake string ID or let's retrieve the user on all the examples across languages
- Some of the examples have comments on both retrieving all and retrieving child API keys, let's please ensure all examples have the comment on both to help distinguish each section of the example and that the wording is uniform across them all
You're right. This is a WIP, still waiting for the method to get implemented in the Go library and for the methods to be moved to the right service on each library to continue. |
|
Fair enough! I'll mark this as a draft until it's ready. Feel free to publish at that time. |
dcaballeroc
force-pushed
the
update-api-key-retrieval-examples
branch
from
9623350 to
b3b029f
Compare
jchen293
approved these changes
Oct 11, 2023
nwithan8
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the functions are available for a next release on C# and Node libraries, add examples to get API Keys for child users for these. It also add missing example for Java library, which already has that functionality.