Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test on python 3.13 #352

Merged
merged 3 commits into from
Oct 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,17 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.12'
python-version: '3.13'
- name: Install Dependencies
run: make install
- name: Lint
run: make lint
run-tests:
runs-on: ubuntu-latest
# TODO: Use `latest` once we drop support for Python 3.7
runs-on: ubuntu-22.04
strategy:
matrix:
pythonversion: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12']
pythonversion: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
Expand All @@ -47,7 +48,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.12'
python-version: '3.13'
- name: Install Dependencies
run: make install
- name: Generate Docs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: '3.12'
python-version: '3.13'
- name: Build package
run: make install build
- name: Publish to PyPI
Expand Down
8 changes: 2 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,7 @@ lint-fix: black isort

## mypy - Run mypy type checking on the project
mypy:
$(VIRTUAL_BIN)/mypy $(PROJECT_NAME)/ $(TEST_DIR)/ --config-file examples/style_guides/python/pyproject.toml

## publish - Publish the project to PyPI
publish:
$(VIRTUAL_BIN)/twine upload dist/*
$(VIRTUAL_BIN)/mypy $(PROJECT_NAME)/ $(TEST_DIR)/ --config-file examples/style_guides/python/pyproject.toml --install-types --non-interactive

## release - Cuts a release for the project on GitHub (requires GitHub CLI)
# tag = The associated tag title of the release
Expand All @@ -88,4 +84,4 @@ scan:
test:
$(VIRTUAL_BIN)/pytest

.PHONY: help black black-check build clean coverage docs flake8 install isort isort-check lint lint-fix mypy publish release scan test
.PHONY: help black black-check build clean coverage docs flake8 install isort isort-check lint lint-fix mypy release scan test
3 changes: 0 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
"pytest-cov==4.*",
"pytest-vcr==1.*",
"pytest==7.*",
"twine==5.*;python_version>='3.8'", # TODO: remove python pin when 3.7 is dropped
"types-requests",
"types-urllib3",
Justintime50 marked this conversation as resolved.
Show resolved Hide resolved
"vcrpy==4.*", # TODO: vcrpy v5 requires Python 3.8+
]

Expand Down