Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] New utility script to find and replace version number #325

Closed
wants to merge 1 commit into from

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Jan 8, 2024

Description

  • A new utility script, called via make prep-release version="x.x.x" date="xxxx-xx-xx" that will find and update version numbers in:
    • setup.py
    • easypost/constants.py
    • CHANGELOG.md
  • version required for script/make step, date optional (will use today's date if not provided)

Testing

  • Confirmed working via multiple manual tests

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested review from a team, jchen293 and Justintime50 January 8, 2024 21:39
@nwithan8 nwithan8 changed the title [chore] New utility script to find and replace version number [POC] New utility script to find and replace version number Jan 8, 2024
@Justintime50
Copy link
Member

Let's have you demo this in the coming days to us. My concern is that we'd potentially overwrite a package version

@nwithan8 nwithan8 marked this pull request as draft January 19, 2024 17:10
@Justintime50
Copy link
Member

Do we still want to pursue this? My thinking is it's easier to update 2-3 file versions than it is to build out automation for this heh. With the rest of the releasing process automated now, the version bump diff is an acceptable manual step to take.

@nwithan8 nwithan8 closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants