Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove create_and_buy from batch #310

Merged
merged 1 commit into from
Nov 29, 2023
Merged

remove create_and_buy from batch #310

merged 1 commit into from
Nov 29, 2023

Conversation

jchen293
Copy link
Member

Description

Removed the undocumented createAndBuy function from the Batch service. The proper usage is to create a batch first and buy it separately

Testing

Unit test is removed

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@jchen293 jchen293 requested a review from a team November 28, 2023 22:43
@jchen293 jchen293 merged commit df53807 into master Nov 29, 2023
8 checks passed
@jchen293 jchen293 deleted the remove_create_and_buy branch November 29, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

@nwithan8 nwithan8 nwithan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchen293 @nwithan8 @Justintime50