Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add dedicated API Keys service #297

Merged
merged 4 commits into from
Sep 28, 2023
Merged

[feat] Add dedicated API Keys service #297

merged 4 commits into from
Sep 28, 2023

Conversation

nwithan8
Copy link
Contributor

Description

  • Add dedicated API Key-related service, available via the api_keys property of a client
    • NOTE: Please note the naming. The api_key property of a client is the currently-used API key string, while the api_keys property is the service for managing API keys.
  • Migrate API key-related functions to API Keys service, deprecated in User service

Testing

  • Migrate unit tests, re-record cassettes as needed

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

- Migrate API key-related functions to API Keys service, deprecated in User service
- Migrate unit tests, re-record cassettes as needed
@nwithan8 nwithan8 requested a review from a team September 27, 2023 19:20
easypost/services/api_key_service.py Outdated Show resolved Hide resolved
easypost/services/api_key_service.py Outdated Show resolved Hide resolved
@nwithan8 nwithan8 requested a review from jchen293 September 28, 2023 18:37
@nwithan8 nwithan8 merged commit 12fb767 into master Sep 28, 2023
@nwithan8 nwithan8 deleted the api_keys branch September 28, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants