Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix parameters for child user pagination #346

Merged
merged 1 commit into from
Aug 8, 2024
Merged

[bug] Fix parameters for child user pagination #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## v7.4.0 (2024-07-24)

- Adds new `Claim` service for filing claims on EasyPost shipments and insurances
- Fix parameters for retrieving next page of child users

## v7.3.0 (2024-07-12)

Expand Down
2 changes: 1 addition & 1 deletion lib/EasyPost/Service/UserService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ public function getNextPageOfChildren(mixed $children, ?int $pageSize = null): m

$params = [
'page_size' => $pageSize,
'before_id' => $userArray[count($userArray) - 1]['id']
'after_id' => $userArray[count($userArray) - 1]['id']
];

if (isset($userParams)) {
Expand Down
129 changes: 103 additions & 26 deletions test/cassettes/users/getNextPageOfChildren.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading