Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove the incorrect inclusion of shipment prop on pickup model #327

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: remove the incorrect inclusion of shipment prop on pickup model #327

merged 1 commit into from
Dec 11, 2023

Conversation

Justintime50
Copy link
Member

Description

There is no shipment property of a Pickup object, remove it from the docstring

Testing

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team December 11, 2023 22:26
@Justintime50 Justintime50 merged commit fcba704 into master Dec 11, 2023
6 checks passed
@Justintime50 Justintime50 deleted the remove_pickup_shipment_prop branch December 11, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 approved these changes

@nwithan8 nwithan8 nwithan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Justintime50 @nwithan8 @jchen293