Fixes polly in ep tests #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good and unit tests passed, if you can address the CVE in the linting step. |
|
How can I address the CVE? |
|
@ralexmatthews either by bumping the bad dependency or adding it to the ignore list |
|
Ah I see. I thought you were referring to the security thing you sent me that prompted this change lol pushed changes 👍 |
nwithan8
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an alert that there was an auth header in some of the cassettes in the easypost request hooks tests. I believe this is because we weren't using polly correctly in those tests.
This PR basically just changes how we init polly and the EP client to be more consistent with the other tests, and then re-records the cassettes.
Testing
This is only testing changes, so I ran the tests and they passed
Pull Request Type
Please select the option(s) that are relevant to this PR.