Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Outdated TypeScript definition for Shipment buy function #479

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

nwithan8
Copy link
Member

Description

  • Fix outdated TypeScript definition for Shipment buy function, account for EndShipper ID
  • Fix unit test for Shipment buy with EndShipper that wasn't passing variables properly

Closes #478

Testing

  • Re-recorded cassette for Shipment buy with EndShipper

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

- Fix unit test for Shipment buy with EndShipper
@nwithan8 nwithan8 requested review from a team, jchen293 and Justintime50 September 27, 2024 23:40
@nwithan8 nwithan8 merged commit 3fd6e74 into master Sep 30, 2024
14 checks passed
@nwithan8 nwithan8 deleted the endshipper_buy_definition branch September 30, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: can't pass in endshipperId parameter when buying a shipment
2 participants