Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Remove carbon offset #423

Merged
merged 3 commits into from
Nov 30, 2023
Merged

[chore] Remove carbon offset #423

merged 3 commits into from
Nov 30, 2023

Conversation

nwithan8
Copy link
Contributor

Description

  • Remove withCarbonOffset parameter from shipment create and buy functions
  • Remove carbon_offset property of Rate object
  • Remove carbon offset-related TypeScript definitions

Testing

  • Remove carbon offset unit tests
  • Remove old cassettes, re-record as needed

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8
- Pull in updated submodule
dfd5f31
@nwithan8
- Remove withCarbonOffset parameter for shipment creation and buy f…
8378d8e 
…unctions

- Remove `carbon_offset` property of `Rate` object
- Remove carbon offset unit tests, TypeScript definitions
- Remove old cassettes, re-record as needed
@nwithan8 nwithan8 requested a review from a team November 30, 2023 22:05
ralexmatthews
ralexmatthews approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@ralexmatthews ralexmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@nwithan8 nwithan8 merged commit b70489a into master Nov 30, 2023
6 checks passed
@nwithan8 nwithan8 deleted the carbon_offset branch November 30, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexmatthews ralexmatthews ralexmatthews approved these changes

@jchen293 jchen293 jchen293 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @ralexmatthews