Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Remove bad guard clause on pagination handling #419

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[fix] Remove bad guard clause on pagination handling #419

merged 1 commit into from
Nov 2, 2023

Conversation

nwithan8
Copy link
Contributor

Description

Testing

  • Add unit test to verify pagination workflow retrieves all valid pages

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team October 31, 2023 18:42
@nwithan8
- Remove bad guard clause on pagination handling
7d30def 
- Add unit test to verify pagination workflow retrieves all valid pages
@nwithan8 nwithan8 requested a review from jchen293 October 31, 2023 19:37
@nwithan8 nwithan8 merged commit 4f75889 into master Nov 2, 2023
6 checks passed
@nwithan8 nwithan8 deleted the pagination branch November 2, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justintime50 Justintime50 Justintime50 approved these changes

@jchen293 jchen293 jchen293 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @Justintime50