Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove carbon offset parameter and batch create_and_buy function #292

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

jchen293
Copy link
Member

@jchen293 jchen293 commented Nov 29, 2023

Description

  • Removed withCarbonOffset parameter from create, buy, and regenerateRates functions, this includes the overload functions that used to have the withCarbonOffset parameter
  • Removes the undocumented createAndBuy function from the Batch service. The proper usage is to create a batch first and buy it separately

Testing

Removed relevant tests and re-recorded the cassettes.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@jchen293 jchen293 requested a review from a team November 29, 2023 21:10
@jchen293 jchen293 merged commit b587264 into master Nov 29, 2023
16 checks passed
@jchen293 jchen293 deleted the remove_carbon_offset_param branch November 29, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants