Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add claims API service #576

Merged
merged 7 commits into from
Jul 24, 2024
Merged

[feat] Add claims API service #576

merged 7 commits into from
Jul 24, 2024

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Jul 22, 2024 •
edited
Loading

Description

Add Claim service:

  • Create a claim
  • Retrieve a claim
  • List all claims (paginated)
  • Get the next page of claims
  • Cancel a claim

Add associated Claim, ClaimCollection and ClaimHistoryEntry classes
Add associated ClaimType and ClaimPaymentMethod enums

Testing

  • Added unit tests, fixtures and cassettes as needed

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

nwithan8 added 3 commits July 22, 2024 14:12
@nwithan8
- Add new Claim service, functions
b7194bb 
- Add new Claim and ClaimHistoryEntry models
- Add unit tests, fixtures, cassettes as needed
- Bump examples submodule
- TODO: Docstring updates
@nwithan8
- Change base class for ClaimHistoryEntry to ephemeral
956b6ce
@nwithan8
- Linting
eaccbad
@nwithan8 nwithan8 requested a review from a team July 22, 2024 20:20
nwithan8 added 2 commits July 22, 2024 14:27
@nwithan8
- Add missing cassettes
be7bd0d 
- Update integration tests with new classes
@nwithan8
- Use enum for claim payment method
5ba9e49
ralexmatthews
ralexmatthews approved these changes Jul 23, 2024
View reviewed changes
Copy link

@ralexmatthews ralexmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 lots of github linting comments on it tho lol

EasyPost/Models/API/ClaimType.cs Show resolved Hide resolved
ralexmatthews
ralexmatthews approved these changes Jul 23, 2024
View reviewed changes
Copy link

@ralexmatthews ralexmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sick 👌

@nwithan8 nwithan8 merged commit 9540e8a into master Jul 24, 2024
14 checks passed
@nwithan8 nwithan8 deleted the claims branch July 24, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchen293 jchen293 jchen293 left review comments

@ralexmatthews ralexmatthews ralexmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwithan8 @jchen293 @ralexmatthews