-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Support new UPS carrier account create/update endpoint #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mark legacy (dictionary) carrier account creation function as deprecated (does not support FedEx and UPS registrations) - Introduce new error type raised if invalid function called (guard clause for legacy carrier account creation function)
…UPS-specific tests - Add required test fixtures
- New parameter sets for UPS update
- Add/re-record cassettes as needed
EasyPost.Tests/ServicesTests/WithParameters/CarrierAccountServiceTest.cs
Outdated
Show resolved
Hide resolved
Justintime50
approved these changes
Jul 11, 2024
jchen293
reviewed
Jul 12, 2024
Co-authored-by: Jack Chen <[email protected]>
jchen293
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Outside of obsolete warnings (and guard clauses if users decide to ignore the obsolete warnings), there are no breaking changes to existing workflows. Only those creating/editing UPS accounts will need to account for the changes made in this PR.
Testing
Pull Request Type
Please select the option(s) that are relevant to this PR.