-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove underline from link variant #1532
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, are there any stories, etc. that need to be updated?
@Brattin11 Just checked to see if any stories or anything else needed updating and all looks good! Nothing else to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after thinking about this more and looking at the surface area of current link
usage in our code i think it'd be best to make this a new variant instead of modifying the link
variant.
in the design system it's called Text
(Button style=Text
), so we could make a new text
variant for Button
that is the same styles and code as the link
variant but without the underline, and leave the link
variant untouched.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you change the PR title to match what is happening in the code?
.variantText { | ||
@include Button.variantText; | ||
} | ||
|
||
.variantOutlined, | ||
.variantLink { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.variantLink { | |
.variantLink, | |
.variantText { |
π Changes
Please provide a brief summary of the changes made and why they were made.
Include any notes, screenshots, or videos that may be helpful for developers reviewing this pull request.
β Checklist
Easy UI has certain UX standards that must be met. In general, non-trivial changes should meet the following criteria:
Strikethroughany items that are not applicable to this pull request.