Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ci job timeouts #1442

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fullkomnun
Copy link
Contributor

A few suggestions for the ci workflows:

  1. The default time-out for a github ci job is 360m (6h) and unfortunately setting a default time-out at the entire workflow scope is not yet supported so to prevent a job from hanging for so long, it is useful to set a sensible (but not too strict) time-out per job explicitly (specific limits are flexible)
  2. A nice optimization: when triggered due to a PR and new commits are pushed while jobs are still in-progress they will be cancelled in favor of the newly triggered jobs (stopping stale jobs running on invalidated PR)
  3. (optional) Also added 'workflow_dispatch' as a trigger so that workflow can be started manually via web (Actions tab) to anyone who has permissions to do so (will only appear there after PR is merged). Useful for troubleshooting and nicer than empty commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant