start-apps script can now select apps to start #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
The
start-appsscript previously ran up both the Proposer and Challenger apps. This is a little inflexible. One may wish just to run a Challenger for example. This change adds flexibility to the script to select which containers to start, either on the command line or via and environment variable.This PR also contains a new environment file, suitable for running a challenger on Mumbai. It's not really connected to this R but too small a change (and purely additive) to be worth a separate PR.
Does this close any currently open issues?
No
What commands can I run to test the change?
You can use the script to start apps, do
bin/start-apps -hfor info. You don't need anything else running to see the containers start, although they will fail when they look for an optimist but the script has done it's work by then.