fix: do not show translation as completed when there are failing checks

See WeblateOrg#13669
ESEHUMPS · Jan 28, 2025 · dd135b9 · dd135b9
1 parent e845446
commit dd135b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/weblate/templates/snippets/list-objects.html b/weblate/templates/snippets/list-objects.html
@@ -153,7 +153,7 @@
           {% if project and project.enable_review %}
             {% review_percent category.stats %}
           {% endif %}
-          {% list_objects_percent percent=category.stats.translated_percent value=category.stats.translated search_url=search_url translate_url=translate_url  query="q=state:>=translated" total=category.stats.all %}
+          {% list_objects_percent percent=category.stats.translated_percent value=category.stats.translated search_url=search_url translate_url=translate_url  query="q=state:>=translated" total=category.stats.all checks=category.stats.allchecks %}
           {% if not hide_details %}
             {% list_objects_number value=category.stats.todo search_url=search_url translate_url=translate_url query="q=state:<translated " css="zero-width-640" %} {% list_objects_number value=category.stats.todo_words search_url=search_url translate_url=translate_url query="q=state:<translated" css="zero-width-720" %} {% list_objects_number value=category.stats.todo_chars search_url=search_url translate_url=translate_url query="q=state:<translated" css="zero-width-1200" %} {% list_objects_number value=category.stats.nottranslated search_url=search_url translate_url=translate_url query="q=state:empty" css="zero-width-1400" %} {% list_objects_number value=category.stats.allchecks search_url=search_url translate_url=translate_url query="q=has:check" css="zero-width-768" %} {% list_objects_number value=category.stats.suggestions search_url=search_url translate_url=translate_url query="q=has:suggestion#suggestions" css="zero-width-900" %} {% list_objects_number value=category.stats.comments search_url=search_url translate_url=translate_url query="q=has:comment#comments" css="zero-width-1000" %}
           {% endif %}
@@ -261,7 +261,7 @@
           {% if is_glossary %}
             {% list_objects_number value=object.stats.translated search_url=search_url translate_url=translate_url query="q=state:>=translated" show_zero=True %}
           {% else %}
-            {% list_objects_percent percent=object.stats.translated_percent value=object.stats.translated search_url=search_url translate_url=translate_url query="q=state:>=translated" total=object.stats.all %}
+            {% list_objects_percent percent=object.stats.translated_percent value=object.stats.translated search_url=search_url translate_url=translate_url query="q=state:>=translated" total=object.stats.all checks=object.stats.allchecks %}
           {% endif %}
           {% if not hide_details %}
             {% list_objects_number value=object.stats.todo search_url=search_url translate_url=translate_url query="q=state:<translated" css="zero-width-640" %}

diff --git a/weblate/trans/templatetags/translations.py b/weblate/trans/templatetags/translations.py
@@ -838,6 +838,7 @@ def review_percent(obj):
         percent=stats.approved_percent + stats.readonly_percent,
         query="q=state:>=approved",
         total=stats.all,
+        checks=stats.allchecks,
         css="zero-width-540",
     )
 
@@ -1490,6 +1491,7 @@ def list_objects_percent(
     percent: float,
     value: int,
     total: int,
+    checks: int,
     search_url: str | None = None,
     translate_url: str | None = None,
     query: str = "",
@@ -1507,7 +1509,7 @@ def list_objects_percent(
     else:
         url_start = url_end = ""
 
-    if value and value == total:
+    if value and value == total and checks == 0:
         percent_formatted = format_html(
             """<span class="green" title="{}">{}</span>""",
             ngettext(