Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieval of dstStatusField and optionally writing to file; add mapbilnr_nstod mapping #169

Merged
merged 7 commits into from
Mar 28, 2021

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Mar 24, 2021

Description of changes

Adds ability to write dstStatusField from RegridStore. Adds bilinear mapping with NSTOD extrapolation.

Specific notes

A flag is added (dststatus_print, default false) in med_map_mod.F90 to write the dstStatusField from the RegridStore operation. Since ESMF_FieldWrite does not order the written field correctly, a field containing the index order is also retrieved and written. This can be used off-line to re-order the data in the dststatus file.

A bilinear mapping type with NSTOD extrapolation is added. This is currently unused but will be implemented in the ufs-model system for mapping the ATM states (bottom T,P,Q,U,V) using bilinear instead of conservative mapping.

A small change is added to abort if coupling_mode is not supported.

Trailing white space cleanup, primarily in fd_nems.yaml

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):
NOAA-EMC#38

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes
  • No

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines:
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail
    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description: ufs-weather-model (3e46f5b) switched to this branch for CMEPS with shr_mod_pio.F90 from CMakeLists.txt in CMEPS-interface
    • details (e.g. failed tests): All ufs-coupled and ufs-datm tests pass current baselines
      CESM - verified that SMS_Vnuopc_Ld1.f09_g17.B1850.cheyenne_intel was bfb with these changes

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch:
    • hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch:
    • hash:

Copy link
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test this PR with HAFS and get back to you soon.

mediator/med_map_mod.F90 Show resolved Hide resolved
mediator/med_phases_prep_glc_mod.F90 Show resolved Hide resolved
Copy link
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run fully coupled HAFS configuration and it is bit-to-bit. So, I am approving this PR.

@mvertens mvertens removed the request for review from jedwards4b March 28, 2021 17:35
@mvertens mvertens self-assigned this Mar 28, 2021
@mvertens mvertens merged commit df76314 into ESCOMP:master Mar 28, 2021
@DeniseWorthen DeniseWorthen deleted the feature/dstmapbilnPR branch June 1, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants