Fix CCPP Fortran parser / build error with tropopause_find #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CCPP Fortran parser is not able to read module variables of character type defined with the shr_kind_cl parameter size. The tropopause_climo_file variable does not need to be a CCPP variable so it has been removed. This will fix the build process again.
|
OK I have confirmed this time that with all the modifications all tests pass on Derecho (except the submit step)! |
nusbaume
approved these changes
Oct 8, 2024
peverwhee
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CCPP Fortran parser is not able to read module variables of character type defined with the
shr_kind_clparameter size.The
tropopause_climo_filevariable does not need to be a CCPP variable anyway so it has been removed. This will fix the build process again.Verified that it builds (need to either remove
tropopause_diagnosticsfrom tropopause_find test SDF -or- merge the history PR) and runs with CAM snapshot.