feat!: allow to encode array index using dynamicKeyPart in encodeData + return dynamicName with getSchema for Arrays
#449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJ42
force-pushed
the
feat/array-index-encoding
branch
from
50c80d4 to
a36f694
Compare
Hugoo
approved these changes
May 21, 2024
| keyType: 'Singleton', | ||
| valueContent: 'Address', | ||
| valueType: 'address', | ||
| }, | ||
| '0xdf30dba06db6a30e65354d9a64c6098600000000000000000000000000000000': { | ||
| name: 'AddressPermissions[0]', | ||
| name: 'AddressPermissions[]', |
There was a problem hiding this comment.
This is a breaking change - we need to flag it as such
CJ42
changed the title
dynamicKeyPart in encodeData + return dynamicName with getSchema for ArraysdynamicKeyPart in encodeData + return dynamicName with getSchema for Arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
🌟 Feature
What is the current behaviour (you can also link to an open issue here)?
Currently, it is not possible when using
encodeDatato simply encode array index data keys.What is the new behaviour (if this is a feature change)?
Add feature for arrays that enable to pass a
dynamicKeyPartas anumberthat will encode for an array index.Other information: