feat: map permission and permissions docs section #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJ42
force-pushed
the
feat/map-permission-and-permissions-docs-section
branch
from
db23a9d to
c447bba
Compare
CJ42
changed the title
richtera
approved these changes
May 13, 2024
| ```js | ||
| import { isDataAuthentic } from '@erc725/erc725.js'; | ||
|
|
||
| isDataAuthentic(data, verificationOptions); |
There was a problem hiding this comment.
Note this will not always work for the decoded json data unfortunately. If the checksum was pretty printed then the data needs to be the byte array of the file.
richtera
approved these changes
May 15, 2024
CJ42
force-pushed
the
feat/map-permission-and-permissions-docs-section
branch
from
c447bba to
18b8a93
Compare
CJ42
force-pushed
the
feat/map-permission-and-permissions-docs-section
branch
from
18b8a93 to
5e300f0
Compare
CJ42
force-pushed
the
feat/map-permission-and-permissions-docs-section
branch
from
5e300f0 to
8b2bb98
Compare
Hugoo
reviewed
May 21, 2024
There was a problem hiding this comment.
I see the docs are already live for this feature:
https://docs.lukso.tech/tools/erc725js/methods#mappermission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
✨ Feature
What is the current behaviour (you can also link to an open issue here)?
The function
mapPermissioncan be useful to retrieve the bytes32 hex value of a permission given its name. However, it is not available.What is the new behaviour (if this is a feature change)?
Export the
mapPermissionfunction to make it available in the library + refactor it to returnnullwhen the permission name is not known instead of throwing an error.