feat: add support for encoding bytes1
to bytes32
+ fix incorrect encoding uintN
#427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
⭐ Feature
🐛 Bug Fix
What is the current behaviour (you can also link to an open issue here)?
Bug
When encoding
uintN
in tuples and thevalueContent
isNumber
, these are always encoded to auint256
as a 32 bytes long value because of the following line in the code:erc725.js/src/lib/encoder.ts
Lines 675 to 690 in 06d872b
Missing Feature
Additionally, there is only support for few
bytesN
types, likebytes2
,bytes4
,bytes8
, etc...What is the new behaviour (if this is a feature change)?
This the padding for the encoding of uintN and bytesN + add support for multiple
bytesN