Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow LF or TAB in the middle of JSON detection #391

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

richtera
Copy link
Collaborator

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

Allow JSON detection to work if there is a LF right before and after the end.

What is the current behaviour (you can also link to an open issue here)?

What is the new behaviour (if this is a feature change)?

Other information:

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.12%. Comparing base (945210a) to head (315fa54).

Files Patch % Lines
src/lib/getDataFromExternalSources.ts 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #391   +/-   ##
========================================
  Coverage    82.12%   82.12%           
========================================
  Files           19       19           
  Lines         1309     1309           
  Branches       302      302           
========================================
  Hits          1075     1075           
  Misses         128      128           
  Partials       106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richtera
Copy link
Collaborator Author

richtera commented Mar 9, 2024

@Hugoo This one is required first.

@CJ42 CJ42 merged commit c915304 into develop Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants