Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: merge to main #388

Merged
merged 7 commits into from
Feb 23, 2024
Merged

release: merge to main #388

merged 7 commits into from
Feb 23, 2024

Conversation

richtera
Copy link
Collaborator

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

  • fix: Re-do PR with minimal changes
  • fix: Missing line
  • fix: Add check for pretty printed and non-pretty printed versions of JSON

What is the current behaviour (you can also link to an open issue here)?

What is the new behaviour (if this is a feature change)?

Other information:

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 82.12%. Comparing base (e7ed169) to head (945210a).
Report is 215 commits behind head on main.

Files Patch % Lines
src/lib/getDataFromExternalSources.ts 50.00% 2 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   83.42%   82.12%   -1.31%     
==========================================
  Files          18       19       +1     
  Lines        1062     1309     +247     
  Branches      234      302      +68     
==========================================
+ Hits          886     1075     +189     
- Misses         96      128      +32     
- Partials       80      106      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richtera richtera merged commit aa39922 into main Feb 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants