Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix LF JSON parsing issue and add some exports (no upgrades or other changes) #385

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

richtera
Copy link
Collaborator

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

Add handling of EOF LF for JSON parsing
Add some additional esm exports

What is the current behaviour (you can also link to an open issue here)?

What is the new behaviour (if this is a feature change)?

Other information:

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 82.12%. Comparing base (e46dfd8) to head (aa68bf1).

Files Patch % Lines
src/lib/getDataFromExternalSources.ts 50.00% 2 Missing and 4 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #385      +/-   ##
===========================================
- Coverage    82.30%   82.12%   -0.18%     
===========================================
  Files           19       19              
  Lines         1294     1309      +15     
  Branches       298      302       +4     
===========================================
+ Hits          1065     1075      +10     
- Misses         126      128       +2     
- Partials       103      106       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richtera richtera merged commit 1796043 into develop Feb 23, 2024
2 checks passed
@richtera richtera deleted the fix/minimal-updates branch February 23, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants