chore: sync main #376
Merged
chore: sync main #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Add workaround to read (bytes4,URI), repair unknown signature to pass.
…cessible withing getDataFromExternalSources.
fix: Make data retrieval more resilient. Do not throw on ipfs data problems.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
- Coverage 83.18% 82.86% -0.33%
==========================================
Files 19 19
Lines 1231 1243 +12
Branches 282 286 +4
==========================================
+ Hits 1024 1030 +6
- Misses 110 115 +5
- Partials 97 98 +1 ☔ View full report in Codecov by Sentry. |
feat: add permission related to 4337
|
@CJ42 Ok I will close my merge branch. They are not identical :) |
… output data type.
…uffer no matter what.
fix: Add more resiliency to library
richtera
approved these changes
Jan 22, 2024
* docs: Add TypeScript to getting started page * Apply suggestions Co-authored-by: Hugo Masclet <[email protected]> * add schema notice + add type to schema * apply suggestions, add changes to README --------- Co-authored-by: Hugo Masclet <[email protected]>
chore: run tests on node 18 and 20
feat: allow to import TS typed schemas from `@erc725/erc725.js/schemas`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.