Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add permission related to 4337 #374

Merged
merged 1 commit into from
Jan 16, 2024
Merged

feat: add permission related to 4337 #374

merged 1 commit into from
Jan 16, 2024

Conversation

CJ42
Copy link
Collaborator

@CJ42 CJ42 commented Jan 10, 2024

Copy link
Collaborator

@richtera richtera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably use ERC4337_PERMISSION and not just 4337_PERMISSION because without the ERC prefix it's not a legitimate identifier.

docs/classes/ERC725.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (330c604) 83.18% compared to head (e7fd19b) 82.86%.
Report is 14 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #374      +/-   ##
===========================================
- Coverage    83.18%   82.86%   -0.33%     
===========================================
  Files           19       19              
  Lines         1231     1243      +12     
  Branches       282      286       +4     
===========================================
+ Hits          1024     1030       +6     
- Misses         110      115       +5     
- Partials        97       98       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richtera richtera merged commit afd6885 into develop Jan 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants