Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for multi dynamic key name #357

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

Hugoo
Copy link
Contributor

@Hugoo Hugoo commented Nov 23, 2023

@Hugoo Hugoo force-pushed the feat-multi-type-name branch from 3a9696f to 1e7989b Compare November 27, 2023 15:42
@codecov-commenter
Copy link

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (9640d9f) 83.71% compared to head (1e7989b) 83.55%.
Report is 22 commits behind head on develop.

Files Patch % Lines
src/lib/encoder.ts 87.27% 7 Missing and 7 partials ⚠️
src/lib/utils.ts 80.76% 5 Missing and 5 partials ⚠️
src/index.ts 66.66% 4 Missing ⚠️
src/lib/getDataFromExternalSources.ts 33.33% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #357      +/-   ##
===========================================
- Coverage    83.71%   83.55%   -0.17%     
===========================================
  Files           18       18              
  Lines         1130     1204      +74     
  Branches       255      272      +17     
===========================================
+ Hits           946     1006      +60     
- Misses          98      105       +7     
- Partials        86       93       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@CallumGrindle CallumGrindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though Im not sure I fully understand how the duplicateMultiTypeERC725SchemaEntry works.
We create schemas for each possible typing, and progress as if each one was passed individually. How are we sure that the correct type is used for encoding/decoding? I may lack context

@Hugoo
Copy link
Contributor Author

Hugoo commented Nov 27, 2023

lgtm, though Im not sure I fully understand how the duplicateMultiTypeERC725SchemaEntry works. We create schemas for each possible typing, and progress as if each one was passed individually. How are we sure that the correct type is used for encoding/decoding? I may lack context

The correct type is given by the user. The user will use the lib like this:

image

And because of this "duplicate step" the lib will be able to encode/decode properly.

@Hugoo Hugoo merged commit ba92903 into develop Nov 27, 2023
2 checks passed
@Hugoo Hugoo deleted the feat-multi-type-name branch November 27, 2023 15:57
This was referenced May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: encodeKeyName does not work for LSP8 keys that contain multiple types in dynamic key parts
4 participants