Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming hashFunction #333

Merged

Conversation

kalote
Copy link
Contributor

@kalote kalote commented Oct 31, 2023

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

  • Rename hashFunction to verificationFunction
  • Rename hash to verificationData
  • Rename some function names for consistency
  • Rename some variables names for consistency
  • Rename some constants for consistency

What is the current behaviour (you can also link to an open issue here)?

What is the new behaviour (if this is a feature change)?

same behaviour, different variable names

Other information:

README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Merging #333 (a7c60d0) into develop (122efa9) will increase coverage by 0.85%.
Report is 84 commits behind head on develop.
The diff coverage is 90.24%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #333      +/-   ##
===========================================
+ Coverage    83.04%   83.89%   +0.85%     
===========================================
  Files           18       18              
  Lines          979     1124     +145     
  Branches       218      252      +34     
===========================================
+ Hits           813      943     +130     
- Misses          91       97       +6     
- Partials        75       84       +9     
Files Coverage Δ
src/constants/constants.ts 100.00% <100.00%> (ø)
src/constants/interfaces.ts 100.00% <100.00%> (ø)
src/index.ts 77.22% <100.00%> (+0.22%) ⬆️
src/lib/detector.ts 96.00% <100.00%> (+8.50%) ⬆️
src/lib/getData.ts 89.79% <ø> (ø)
src/lib/getDataFromExternalSources.ts 63.33% <ø> (-1.19%) ⬇️
src/lib/provider-wrapper-utils.ts 88.88% <ø> (-0.59%) ⬇️
src/schemas/index.ts 100.00% <100.00%> (ø)
src/types/Method.ts 100.00% <100.00%> (ø)
src/lib/decodeMappingKey.ts 84.21% <60.00%> (-5.54%) ⬇️
... and 4 more

... and 3 files with indirect coverage changes

README.md Outdated Show resolved Hide resolved
@CallumGrindle CallumGrindle merged commit 1a1170c into ERC725Alliance:develop Nov 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants