-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/gas param #332
Feat/gas param #332
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #332 +/- ##
===========================================
+ Coverage 83.04% 83.71% +0.67%
===========================================
Files 18 18
Lines 979 1130 +151
Branches 218 255 +37
===========================================
+ Hits 813 946 +133
- Misses 91 98 +7
- Partials 75 86 +11
|
I don't know anything about ts, so I've no idea what and how it works :D... but I would also recommend supporting setting the gas to 0 as a wildcard (or null or something) that would remove the call limit completely and let the node run with whatever cap it has itself. |
Also agree. |
So shall we set the default to 0? @CallumGrindle / @skimaharvey / @Hugoo ? |
Default is 2_000_000 but can be change to 0 if needed via the param. I guess it can be added to the next release @CallumGrindle |
Default gas value set to 1_000_000 (1Gwei). |
What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
New
gas
configuration in the optionalparams
setting:I also removed the
gasPrice
from the constants.ts file as it was unused.What is the current behaviour (you can also link to an open issue here)?
Fix #328
What is the new behaviour (if this is a feature change)?
Other information: