Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect permission value for EXECUTE_RELAY_CALL #327

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

CJ42
Copy link
Collaborator

@CJ42 CJ42 commented Oct 29, 2023

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

bug fix

What is the current behaviour (you can also link to an open issue here)?

The hex literal for permission EXECUTE_RELAY_CALL is incorrect. IT has an extra 4.

What is the new behaviour (if this is a feature change)?

Put the write bytes32 hex value for permission EXECUTE_RELAY_CALL.

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

Merging #327 (55b8f5e) into develop (9f1b5fd) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff            @@
##           develop     #327   +/-   ##
========================================
  Coverage    83.89%   83.89%           
========================================
  Files           18       18           
  Lines         1124     1124           
  Branches       252      252           
========================================
  Hits           943      943           
  Misses          97       97           
  Partials        84       84           
Files Coverage Δ
src/constants/constants.ts 100.00% <ø> (ø)

@CallumGrindle CallumGrindle merged commit f677d3c into develop Oct 30, 2023
2 checks passed
@CallumGrindle CallumGrindle deleted the fix/permissions branch October 30, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants