[Network] Prune / disconnect TCP connections gracefully #4574
+2
−73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue with our server TCP connections not closing gracefully. In the past we've used empty packet keepalives inter-process to have the server prune the connections immediately.
This PR should also significantly reduce keepalive load / chatter with servers with large amounts of processes.
Thanks to solar from Tak for code pairing on related issue #4573
Type of change
Testing
This is after killing 3 zone processes and below we see World disconnect the zoneserver on
UV_EOF
- we would see similarly for any other Server -> Server connection or Server -> Client that uses this connection class (Console, Websocket)Inverse where we kill World and all zones close their connection to World
Similar test with UCS
Checklist